Move api helpers.go to a subpackage #44296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
size/XXL
|
This change is |
caesarxuchao
force-pushed
the
move-api-helpers.go
branch
from
ce168bd
to
9c5e7a4
Compare
caesarxuchao
added
release-note-none
caesarxuchao
force-pushed
the
move-api-helpers.go
branch
2 times, most recently
from
bfe0965
to
2708d2a
Compare
k8s-github-robot
added
the
needs-rebase
caesarxuchao
force-pushed
the
move-api-helpers.go
branch
from
2708d2a
to
70f0ba4
Compare
k8s-github-robot
removed
the
needs-rebase
|
@k8s-bot unit test this |
Merged
lavalamp
reviewed
Apr 11, 2017
| func LoadBalancerStatusDeepCopy(lb *LoadBalancerStatus) *LoadBalancerStatus { | ||
| c := &LoadBalancerStatus{} | ||
| c.Ingress = make([]LoadBalancerIngress, len(lb.Ingress)) | ||
| func LoadBalancerStatusDeepCopy(lb *api.LoadBalancerStatus) *api.LoadBalancerStatus { |
There was a problem hiding this comment.
this function seems bad, are there users of it?
There was a problem hiding this comment.
yeah, a few invocations in pkg/controller/service and pkg/proxy.
lavalamp
reviewed
Apr 11, 2017
pkg/api/helper/helpers.go
Outdated
| c.Message, reflect.TypeOf(c.In), c.In, reflect.TypeOf(c.Out), | ||
| ) | ||
| } | ||
|
|
||
| const ( | ||
| // annotation key prefix used to identify non-convertible json paths. | ||
| NonConvertibleAnnotationPrefix = "non-convertible.kubernetes.io" |
There was a problem hiding this comment.
should this stay in the api package?
There was a problem hiding this comment.
If you address this one, I'll lgtm.
lavalamp
reviewed
Apr 11, 2017
| @@ -301,7 +302,7 @@ func Convert_extensions_ReplicaSet_to_v1_ReplicationController(in *extensions.Re | |||
| if out.Annotations == nil { | |||
| out.Annotations = make(map[string]string) | |||
| } | |||
| out.Annotations[api.NonConvertibleAnnotationPrefix+"/"+fieldErr.Field] = reflect.ValueOf(fieldErr.BadValue).String() | |||
| out.Annotations[helper.NonConvertibleAnnotationPrefix+"/"+fieldErr.Field] = reflect.ValueOf(fieldErr.BadValue).String() | |||
There was a problem hiding this comment.
no need to fix in this PR, but we should probably provide a function instead of making everyone do this concatenation.
|
I have slightly mixed feelings, but overall I think this is a good step. |
caesarxuchao
force-pushed
the
move-api-helpers.go
branch
from
70f0ba4
to
08aa712
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: caesarxuchao, lavalamp
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
Automatic merge from submit-queue |
k8s-github-robot
pushed a commit
that referenced
this pull request
Apr 14, 2017
Automatic merge from submit-queue (batch tested with PRs 44406, 41543, 44071, 44374, 44299) Move pkg/api/ref.go to a subpackage First commit is #44296. (unfortunately, removing that commit results in conflicts) This PR moves the pkg/api/ref.go to its own subpackage. It's mostly a mechanic move. I'll send a few more PRs to make the k8s.io/kubernetes/pkg/api package only contains the code we want in the k8s.io/api repo, then we can run a [script](a0015fd#diff-7a2fbb4371972350ee414c6b88aee1c8) to cut the new repo.
k8s-github-robot
pushed a commit
that referenced
this pull request
Apr 14, 2017
Automatic merge from submit-queue (batch tested with PRs 44440, 44038, 44302, 44316, 43876) Move pkg/api/ref.go and pkg/api/resource_helpers.go to subpackages First two commits are #44296 #44299. (unfortunately, removing these commits results in conflicts) This PR moves resource_helpers.go to a subpackage. It's mostly a mechanic move, except that: * i kept the methods of ResourceName and ResourceList in pkg/api/method.go I'll send one more PR to separate api.Scheme etc. to their own package.
k8s-github-robot
pushed a commit
that referenced
this pull request
Apr 15, 2017
Automatic merge from submit-queue (batch tested with PRs 44364, 44361, 42498) Move v1 helpers The first 3 commits are other PRs. This PR move pkg/api/v1/helpers.go to a subpackage, which is almost symmetric to #44296, where pkg/api/helpers.go was moved. This PR is mostly mechanic, except that 1. moved the 3 methods of Taint and Toleration to pkg/api/methods.go 2. moved constants and types defined in v1/helpers.go to pkg/api/v1/annotataion_key_constants.go and nonstandard_types.go 3. updated staging/copy.sh to copy pkg/api/helpers to client-go, it's otherwise removed from client-go because no other code in client-go depends on the package. Some test code in pkg/controller imports client-go/pkg/api/helpers. After moving api types to its own repo, we can remove these copies of utility function from client-go and ask users to use the ones in the main repo. (This PR breaks a cyclic import problem i met when I tried to move global variables pkg/api/Scheme and Registry to a subpackage)
dims
pushed a commit
to dims/kubernetes
that referenced
this pull request
Feb 8, 2018
Automatic merge from submit-queue (batch tested with PRs 44364, 44361, 42498) Move v1 helpers The first 3 commits are other PRs. This PR move pkg/api/v1/helpers.go to a subpackage, which is almost symmetric to kubernetes#44296, where pkg/api/helpers.go was moved. This PR is mostly mechanic, except that 1. moved the 3 methods of Taint and Toleration to pkg/api/methods.go 2. moved constants and types defined in v1/helpers.go to pkg/api/v1/annotataion_key_constants.go and nonstandard_types.go 3. updated staging/copy.sh to copy pkg/api/helpers to client-go, it's otherwise removed from client-go because no other code in client-go depends on the package. Some test code in pkg/controller imports client-go/pkg/api/helpers. After moving api types to its own repo, we can remove these copies of utility function from client-go and ask users to use the ones in the main repo. (This PR breaks a cyclic import problem i met when I tried to move global variables pkg/api/Scheme and Registry to a subpackage)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #44065.
This PR moves the pkg/api/helpers.go to its own subpackage. It's mostly a mechanic move, except that
I'll send a few more PRs to make the k8s.io/kubernetes/pkg/api package only contains the code we want in the k8s.io/api repo, then we can run a script to cut the new repo.